CI: fix db usage in CI #24529
CI: fix db usage in CI #24529
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24529 +/- ##
===========================================
+ Coverage 31.88% 42.81% +10.93%
===========================================
Files 166 166
Lines 52427 52427
===========================================
+ Hits 16714 22445 +5731
+ Misses 35713 29982 -5731
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24529 +/- ##
===========================================
+ Coverage 31.88% 92.31% +60.43%
===========================================
Files 166 166
Lines 52427 52427
===========================================
+ Hits 16714 48398 +31684
+ Misses 35713 4029 -31684
Continue to review full report at Codecov.
|
|
thanks @datapythonista i think this is good now. |
There was a problem hiding this comment.
Sorry for the trouble.
I pushed a linting fix. I think just adding the brackets after the single/not single filter in run_tests.sh, and changing the and by the or is possibly enough.
But the filter to skip db tests by default is probably too complex for being untested, it's probably a good idea to remove it if the --skip-db is enough.
|
|
||
| - dist: trusty | ||
| env: | ||
| - JOB="2.7" ENV_FILE="ci/deps/travis-27.yaml" PATTERN="not slow and db" | ||
| - JOB="2.7" ENV_FILE="ci/deps/travis-27.yaml" PATTERN="(not slow or (single and db))" |
There was a problem hiding this comment.
Just realized about my mistake now. not slow and db just runs db tests. I think not slow or db should be enough, I guess I'm missing something, but I don't see why the single is needed here.
I think it's probably better to add the brackets in run_tests.sh.
There was a problem hiding this comment.
no, the single that is added makes this a bit odd, eg. we are adding the single and pattern, and we only want to run the db tests when its single
|
@datapythonista so welcome to simplify this, but in a followup. |
* upstream/master: Make DTI[tz]._values and Series[tz]._values return DTA (pandas-dev#24534) CLN: Refactor some sorting code in Index set operations (pandas-dev#24533) Run isort (pandas-dev#24530) CI: fix db usage in CI (pandas-dev#24529)
closes #24528
reverts behavior in #24485
canonical way to run tests is
test_fast.sh(or can also specify-m 'not single'(or--skip-db)